Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add check for protocol S3A (s3 compatible) #1761

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Jan 5, 2024

  • We missed a check in daft-io client that would let s3a protocol use the s3 client.

@github-actions github-actions bot added the bug Something isn't working label Jan 5, 2024
@samster25 samster25 changed the title [BUG] add check for s3a and tests [BUG] Add check for protocol S3A (s3 compatible) Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94bb370) 84.76% compared to head (3fb5088) 84.76%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1761   +/-   ##
=======================================
  Coverage   84.76%   84.76%           
=======================================
  Files          55       55           
  Lines        5554     5554           
=======================================
  Hits         4708     4708           
  Misses        846      846           

@samster25 samster25 merged commit 76b1086 into main Jan 5, 2024
42 checks passed
@samster25 samster25 deleted the sammy/s3a-support branch January 5, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant